Skip to content

Conversation

saewoni
Copy link

@saewoni saewoni commented Sep 29, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@saewoni
Copy link
Author

saewoni commented Oct 2, 2025

From what I remember the field names are case insensitive, do you think it is worth it to add a case to check that? like instead of kubeDnsOverrides we name it KubeDNSoverrides and test the behavior

yes that's a good idea

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@saewoni
Copy link
Author

saewoni commented Oct 3, 2025

/azp run

Copy link

Commenter does not have sufficient privileges for PR 9252 in repo Azure/azure-cli-extensions

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@saewoni saewoni force-pushed the sakwa/feature-localdns-none-input-handling branch from 3c00bcb to 417cf30 Compare October 3, 2025 17:46
@saewoni saewoni requested review from FumingZhang and Copilot October 3, 2025 18:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.

"serveStaleDurationInSeconds": 3600
}
},
"vnetDNSOverrides": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbencardinop , changed the cases of *DnsOverrides to be mixed

@saewoni saewoni requested a review from Copilot October 3, 2025 23:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants