Skip to content

Adding Sentinel and connection string support#6

Open
cjb5790 wants to merge 4 commits into
Azure:mainfrom
cjb5790:master
Open

Adding Sentinel and connection string support#6
cjb5790 wants to merge 4 commits into
Azure:mainfrom
cjb5790:master

Conversation

@cjb5790

@cjb5790 cjb5790 commented Sep 9, 2015

Copy link
Copy Markdown

Utilizing the serviceName property within a connection string, the provider will now discover the master Redis instance and use that IP for it's connection. Support has also been added to use the existing connectionString node of the web.config.

Chris Bohatka added 4 commits September 9, 2015 14:29
Added support for Sentinel Configuration
740fa5e 
-Keys off of serviceName in the connectionString
-Rebuilds config after running 'get-master-addr-by-name' on all
available Sentinels
-Updated naming conventions, removed errant whitespace
Coding standards and conventions update
88ac8f5 
-Updated naming conventions for fields
-Removed redundant qualifiers
-Removed unused using
Removing redundant qualifier
538197c
Added ability to use connectionString node
4e77f06 
-Added new function to retrieve value from connectionString
@azurecla

azurecla commented Sep 9, 2015

Copy link
Copy Markdown

Hi @cjb5790, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@SiddharthChatrolaMs

SiddharthChatrolaMs commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

Please add some unit tests and functional tests to test this behaviour.

@gonace

gonace commented Dec 3, 2015

Copy link
Copy Markdown

It would be awesome if Sentinel support would be added. Is there anything you need help with?

@SiddharthChatrolaMs

SiddharthChatrolaMs commented Dec 7, 2015

Copy link
Copy Markdown
Contributor

@gonace Please add some unit tests and functional tests to test this behavior.

@wakm

wakm commented Dec 30, 2015

Copy link
Copy Markdown

whats the status of this pull request?

@SiddharthChatrolaMs

SiddharthChatrolaMs commented Mar 15, 2016

Copy link
Copy Markdown
Contributor

@wakm @gonace @cjb5790 Please add unit tests and functional tests to test this behavior.

Also resolve merge conflicts.

@nayr006

nayr006 commented May 31, 2017

Copy link
Copy Markdown

What is the status of this pull request?

@mapalan

mapalan commented May 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

I believe that this works now due to enhancements in StackExchange.Redis, as mentioned here. Is connecting to sentinels an issue you are still having?

@stanleysmall-microsoft stanleysmall-microsoft changed the base branch from master to main May 11, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjb5790 @azurecla @SiddharthChatrolaMs @gonace @wakm @nayr006 @mapalan @msftgits