fixes issue with error printing and credentials handling #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue with error printing and credentials handling
Author
|
@microsoft-github-policy-service agree
On 28 Aug 2025, at 6:44 PM, microsoft-github-policy-service[bot] ***@***.***> wrote:
@microsoft-github-policy-service agree
|
|
@awartany the command you issued was incorrect. Please try again. Examples are: and |
howieleung
reviewed
Nov 19, 2025
| # React build output | ||
| src/api/static/react/ | ||
| .vscode/launch.json | ||
| .DS_Store |
| "dev": "vite", | ||
| "build": "tsc && vite build", | ||
| "setup": "npm install -g [email protected] && pnpm install && pnpm build", | ||
| "setup": "pnpm install && pnpm build", |
Collaborator
There was a problem hiding this comment.
This have been resolved in the latest code.
| "@vitejs/plugin-react": "4.4.1", | ||
| "clsx": "2.1.1", | ||
| "copy-to-clipboard": "^3.3.3", | ||
| "prismjs": "1.30.0", |
Collaborator
There was a problem hiding this comment.
This have been resolved in the latest code.
| "remark-supersub": "^1.0.0", | ||
| "vite": "6.3.4", | ||
| "prismjs": "1.30.0" | ||
| "setup": "^0.0.3", |
Collaborator
There was a problem hiding this comment.
This should have been resolved in the latest code.
| search_mgr = SearchIndexManager( | ||
| endpoint=endpoint, | ||
| credential=creds, | ||
| credential=AzureKeyCredential(search_api_key), # <-- Use API key here |
Collaborator
There was a problem hiding this comment.
We shouldn't store api key as env var for security unless the key is set. The latest code is using AAD. So this isn't necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue with error printing and credentials handling