refactor: migrate military generator#1330
Open
SheepFromHeaven wants to merge 7 commits intoAzgaar:masterfrom
Open
refactor: migrate military generator#1330SheepFromHeaven wants to merge 7 commits intoAzgaar:masterfrom
SheepFromHeaven wants to merge 7 commits intoAzgaar:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the military generator from the legacy compiled public/modules script into the TypeScript modules pipeline.
Changes:
- Adds a new
src/modules/military-generator.tsmodule and registers it insrc/modules/index.ts - Updates
Statetyping to support military generation scratch fields - Removes the legacy
<script>include and deletes the oldpublic/modules/military-generator.js
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/states-generator.ts | Extends State interface to support military generation fields |
| src/modules/military-generator.ts | New TS implementation of military generation + global exposure via window.Military |
| src/modules/index.ts | Ensures the new generator module is loaded by the modules entrypoint |
| src/index.html | Removes legacy modules/military-generator.js script include |
| public/modules/military-generator.js | Deletes legacy generated JS implementation |
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning