Skip to content

calc-cbs-params: fix off-by-one on locredit calculation #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

calc-cbs-params: fix off-by-one on locredit calculation #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions misc/calc-cbs-params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ def calc_class_a_credits(
# loCredit for SR class A are calculated following the
# equations L-10 and L-12, respectively.
hicredit = math.ceil(idleslope_a * frame_non_sr / link_speed)
locredit = math.ceil(sendslope_a * max_frame_size_a / link_speed)
# locredit is a negative number, because of sendslope, and thus
# we need to use math.floor() for the ceiling of a negative number
locredit = math.floor(sendslope_a * max_frame_size_a / link_speed)
return hicredit, locredit


Expand Down Expand Up @@ -61,7 +63,8 @@ def calc_class_b_credits(
((frame_non_sr / (link_speed - idleslope_a)) +
(max_frame_size_a / link_speed)))
# loCredit B is calculated following equation L-2.
locredit = math.ceil(sendslope_b * max_frame_size_b / link_speed)
# see comment in calc_class_a_credits() for why we use floor here
locredit = math.floor(sendslope_b * max_frame_size_b / link_speed)
return hicredit, locredit


Expand Down