DO NOT MERGE: Revert CLI e2e tests to check Windows E2E runtime#4056
Draft
gcsecsey wants to merge 4 commits into
Draft
DO NOT MERGE: Revert CLI e2e tests to check Windows E2E runtime#4056gcsecsey wants to merge 4 commits into
gcsecsey wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code cross-checked the set of PRs that introduced the new CLI e2e harness, built the revert branch, and drafted this description.
Proposed Changes
The Windows E2E job started hanging to its 180-minute timeout around June 29. The investigation in AINFRA-2588 traced the onset to the wave of PRs that introduced the new real-CLI e2e test harness (
apps/cli/commands/site/tests/helpers/cli-e2e.ts). Reverting only the Blueprint test (#3961, reverted in #4029) did not fix it — the next Windows run still timed out after ~3 hours. This PR reverts the entire harness so we can observe whether the Windows E2E job returns to its normal runtime without it.windows-x64E2E matrix entry (reverts Disable Studio Windows E2E CI #4039) so this PR's build actually runs the Windows E2E suite. This commit must be dropped or reconciled with AINFRA-2588 before any merge.Two caveats when reading the results: the new CLI e2e tests are vitest tests, so they never ran inside the Playwright E2E job itself — any effect on that job would be indirect (e.g. leaked
process-manager-daemon.mjsprocesses or~/.studiostate accumulating on the persistent Windows agents, matching the CAPACITY_LIMIT_REACHED 36/36 errors seen in the logs). Also, #4034 and #4047 added new Playwright tests (existingapps/studio/e2eharness, not the CLI harness) after Windows E2E was disabled, so this PR's Windows run exercises those for the first time; they are left in place here.Testing Instructions
E2E Tests on windows-x64step.Pre-merge Checklist