Add CLI e2e tests for site management (rename, PHP version, delete)#3989
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Vitest-based end-to-end coverage for the Studio CLI “site management” flows by spawning the built CLI against an isolated config directory and asserting persisted cli.json + on-disk effects.
Changes:
- Adds a new e2e test suite covering
site set --name,site set --php, and updating the WordPressblognameoption viawp option update/get. - Adds destructive-flow coverage for
site deletewith and without--no-files, including verifying on-disk behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude was used to write the end-to-end tests, following the existing CLI e2e harness and patterns. The author directed the scope and approach, verified the tests locally by building the CLI and running the suite, and reviewed the code line by line before creating this PR.
Proposed Changes
Adds end-to-end CLI coverage for the remaining site-management operations that previously had only desktop-UI tests: renaming a site, changing its PHP version, updating the WordPress site title, and deleting a site with and without keeping its files on disk. The tests spawn the built CLI against an isolated config and daemon, so they exercise the real persisted state in
cli.jsonand on disk rather than mocks.Testing Instructions
Expect 5 passing tests. Without
--tagsFilter='e2e'the suite is skipped by design (these are slower, real-CLI tests that run in the release/manual suite, not on every PR).Pre-merge Checklist