Skip to content

Conversation

@katinthehatsite
Copy link
Contributor

@katinthehatsite katinthehatsite commented Nov 5, 2025

Related issues

Closes STU-759

Proposed Changes

  • Please refer to description and details in 195447-ghe-Automattic/wpcom

Testing Instructions

  • Please refer to the testing instructions in 195447-ghe-Automattic/wpcom

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Nov 5, 2025
@katinthehatsite katinthehatsite marked this pull request as draft November 5, 2025 09:44
Kateryna Kodonenko added 2 commits November 5, 2025 10:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

📊 Performance Test Results

Comparing c731e5f vs trunk

site-editor

Metric trunk c731e5f Diff Change
load 13389.00 ms 21854.00 ms +8465.00 ms 🔴 63.2%

site-startup

Metric trunk c731e5f Diff Change
siteCreation 23291.00 ms 25343.00 ms +2052.00 ms 🔴 8.8%
siteStartup 9011.00 ms 6967.00 ms -2044.00 ms 🟢 -22.7%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@katinthehatsite katinthehatsite requested a review from a team November 5, 2025 15:40
@katinthehatsite katinthehatsite marked this pull request as ready for review November 5, 2025 15:40
Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this. LGTM 👍

Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katinthehatsite , it works great! I tested it the PR with the backend PR 195447-ghe-Automattic/wpcom . However I noticed that we are sending paths option, which I believe is not necessary. In that case I also suggest renaming the include_path_list param to avoid confusion with a valid param that uses VaultPress.

@Automattic Automattic deleted a comment from claude bot Nov 18, 2025
@Automattic Automattic deleted a comment from claude bot Nov 18, 2025
@Automattic Automattic deleted a comment from claude bot Nov 18, 2025
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the unused paths option and renaming the param from include_path_list to list_sync_items.

I tested it and it works as expected. I received the email displaying the selected items.

While testing the PR, I found an issue, but it's also present on trunk, so let's fix it separately in STU-1003.

Let's rebase onto trunk and make sure the CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants