-
Notifications
You must be signed in to change notification settings - Fork 51
Studio: Be more specific in push success email by listing individual sync elements #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Studio: Be more specific in push success email by listing individual sync elements #2007
Conversation
…ecific-data-to-backend-for-email
📊 Performance Test ResultsComparing c731e5f vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this. LGTM 👍
sejas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katinthehatsite , it works great! I tested it the PR with the backend PR 195447-ghe-Automattic/wpcom . However I noticed that we are sending paths option, which I believe is not necessary. In that case I also suggest renaming the include_path_list param to avoid confusion with a valid param that uses VaultPress.
…ecific-data-to-backend-for-email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the unused paths option and renaming the param from include_path_list to list_sync_items.
I tested it and it works as expected. I received the email displaying the selected items.
While testing the PR, I found an issue, but it's also present on trunk, so let's fix it separately in STU-1003.
Let's rebase onto trunk and make sure the CI passes.
Related issues
Closes STU-759
Proposed Changes
Testing Instructions
Pre-merge Checklist