Fix the disabled Transcript action rendering as invisible#4729
Open
kean wants to merge 2 commits into
Open
Conversation
The disabled state used playerContrast06 (10% white), a background-fill color, making the row unreadable on the More Actions sheet. Use playerContrast04 instead so the action looks disabled but stays legible. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kean
added
the
[Type] Bug
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the disabled styling for the Transcript action in the player UI so it remains legible (while still clearly disabled) when an episode has no transcript.
Changes:
- Update the Transcript shelf button disabled tint from
playerContrast06toplayerContrast04. - Update the Transcript row icon/text disabled tint in the “More Actions” sheet from
playerContrast06toplayerContrast04.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| podcasts/TranscriptShelfButton.swift | Uses playerContrast04 for the disabled shelf button tint to keep the icon visible. |
| podcasts/ShelfActionsViewController+Table.swift | Uses playerContrast04 for the disabled Transcript row (icon + text) in the actions table. |
Comment on lines
56
to
58
| // Disable transcript if not available | ||
| let isTranscriptsAndIsDisable = action == .transcript && !isTranscriptEnabled | ||
| if isTranscriptsAndIsDisable { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PCIOS-
When the playing episode has no transcript, the Transcript action in the player's "More Actions" sheet (and the shelf button variant) was tinted with
playerContrast06— white at 10% alpha, a background-fill color — making it render as essentially invisible. This switches the disabled state toplayerContrast04(~30% alpha), which reads as disabled but stays legible on all themes. Tap behavior is unchanged: the disabled action still shows the "transcript not available" toast.|
To test
Checklist
CHANGELOG.mdif necessary.🤖 Generated with Claude Code