Skip to content

Sorting on tvOS: address feedback#4665

Open
kean wants to merge 1 commit into
trunkfrom
kean/tvos-sort-address-feedback
Open

Sorting on tvOS: address feedback#4665
kean wants to merge 1 commit into
trunkfrom
kean/tvos-sort-address-feedback

Conversation

@kean

@kean kean commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Address David's feedback: #4650 (comment)

Screenshot 2026-07-01 at 4 40 35 PM

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

@kean kean added this to the 8.16 milestone Jul 1, 2026
@kean kean requested a review from a team as a code owner July 1, 2026 21:05
@kean kean requested review from SergioEstevao and Copilot and removed request for a team July 1, 2026 21:05
@kean kean force-pushed the kean/tvos-sort-address-feedback branch from 1e98f59 to 405da9e Compare July 1, 2026 21:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the tvOS podcast episode-sorting UI to address prior feedback by making the sort action more explicit and removing now-unused “More” affordances.

Changes:

  • Replaced the header “More” (ellipsis) menu label with a dedicated sort icon (arrow up/down) styled using MoreButtonStyle.
  • Removed the now-unused MoreMenuLabel SwiftUI view.
  • Removed the no-longer-used tv_more_menu localization key.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
podcasts/en.lproj/Localizable.strings Removes the unused tv_more_menu string.
Pocket Casts TV App/UI/Podcasts/PodcastDetailView.swift Updates the episode list header menu to a sort-specific icon and adjusts header spacing.
Pocket Casts TV App/UI/Common/MoreMenuLabel.swift Deletes the unused MoreMenuLabel component.
Comments suppressed due to low confidence (1)

Pocket Casts TV App/UI/Podcasts/PodcastDetailView.swift:165

  • archivedFilterMenu sets the accessibility label on the Menu itself, but sortMenu sets it on the inner Image. On tvOS/SwiftUI this can be less reliable, and it’s inconsistent with the nearby menu. Set the label on the Menu control (and keep the label view purely visual).
        }
        .buttonStyle(MoreButtonStyle())
    }

    private var archivedFilterMenu: some View {
        Menu {

@SergioEstevao SergioEstevao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Can you please add the podcasts_screen_sort_order_changed event to tvOS on Event Horizon?

@kean

kean commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

These events are already being tracked:

🔵 Tracked: podcast_screen_toggle_archived ["show_archived": true]
Called -[UIContextMenuInteraction updateVisibleMenuWithBlock:] while no context menu is visible. This won't do anything.
🔵 Tracked: podcasts_screen_sort_order_changed ["sort_by": "oldest_to_newest"]

I opened a PR adding them to includedPlatforms: https://github.com/Automattic/EventHorizonSchemas/pull/100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants