Hide mini player during multi-selection#4659
Merged
Merged
Conversation
`setTabBarHidden(_:animated:)` is buggy on iOS 27, so make `setEnclosingTabBarHidden` a no-op there for now. A follow-up ticket tracks re-enabling this once Apple fixes the underlying issues. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the app’s “enclosing tab bar hide/show” behavior on iOS 27+ as a workaround for a bug in setTabBarHidden(_:animated:), while preserving the existing behavior on iOS 26.
Changes:
- Short-circuits
setEnclosingTabBarHidden(_:animated:)on iOS 27+ (no-op workaround). - Leaves the iOS 26
UITabBarController.setTabBarHidden(_:animated:)path intact.
Comment on lines
+8
to
+11
| // Workaround: `setTabBarHidden(_:animated:)` is buggy on iOS 27, so we | ||
| // disable tab bar hiding there for now. There's a follow-up ticket to | ||
| // re-enable this once Apple fixes the underlying issues. | ||
| guard #unavailable(iOS 27) else { return } |
kean
changed the title
kean
marked this pull request as ready for review
July 1, 2026 15:52
kean
requested review from
a team and
SergioEstevao
and removed request for
a team
July 1, 2026 15:56
kean
marked this pull request as draft
July 1, 2026 15:57
kean
changed the title
kean
marked this pull request as ready for review
July 1, 2026 16:26
SergioEstevao
requested changes
Jul 1, 2026
SergioEstevao
left a comment
SergioEstevao
left a comment
Contributor
There was a problem hiding this comment.
When testing this on iOS 26 and with the mini-player/tab bar minized I see this effect when activating multi-select
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-07-01.at.22.35.11.mov
Contributor
Author
Good catch. I should've tested this. It was this line: tabBarController.tabBarMinimizeBehavior = .never |
SergioEstevao
approved these changes
Jul 2, 2026
SergioEstevao
left a comment
SergioEstevao
left a comment
Contributor
There was a problem hiding this comment.
Working correctly now, thanks for addressing the bug. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test
Checklist
CHANGELOG.mdif necessary.