Skip to content

Write .nvmrc for explicit-version Windows CI jobs #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mokagio wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Write .nvmrc for explicit-version Windows CI jobs #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ac177
Drop explicit exit from CI nvmrc repo hook
mokagio Jul 2, 2026
950d721
Write .nvmrc for explicit-version Windows CI jobs
mokagio Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .buildkite/hooks/pre-command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

set -euo pipefail

if [[ -z "${NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION:-}" ]]; then
exit 0
if [[ -n "${NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION:-}" ]]; then
printf '%s\n' "$NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION" > .nvmrc
fi
Comment on lines +8 to 10

printf '%s\n' "$NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION" > .nvmrc
6 changes: 6 additions & 0 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ steps:

- label: ":windows: :node: Validate {{ matrix.node }} on Windows"
command: bash .buildkite/verify_node.sh {{ matrix.node }}
env:
# nvm v0.39.4 hangs on the Windows agent when no .nvmrc exists in the
# working directory: its ancestor walk for one loops forever under the
# agent's bash. The version property below still drives the install; this
# .nvmrc only exists to short-circuit that walk.
NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION: "{{ matrix.node }}"
plugins:
- automattic/nvm#${BUILDKITE_COMMIT}:
version: "{{ matrix.node }}"
Expand Down