Experiment: explicit-version Windows jobs with .nvmrc present#29
Draft
mokagio wants to merge 1 commit into
Draft
Experiment: explicit-version Windows jobs with .nvmrc present#29mokagio wants to merge 1 commit into
mokagio wants to merge 1 commit into
Conversation
Experiment to confirm the root cause. The explicit-version Windows jobs hang at HEAD because no `.nvmrc` is in the working directory; build 104 only passed because a `.nvmrc` was committed at the repo root back then. Add `NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION` to the existing hanging jobs so the repository hook writes a `.nvmrc` before the plugin runs — the single variable that separates build 104 from 112/113/114/115. If these jobs pass, `.nvmrc` presence is what prevents the post-checksum hang on the explicit-version path. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mokagio
added a commit
that referenced
this pull request
Jul 2, 2026
The explicit-version Windows jobs hang and get killed (`0xC000013A`): with no `.nvmrc` in the working directory, nvm v0.39.4's ancestor walk loops forever under the Windows agent's bash. Setting `NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION` makes the repo `pre-command` hook write one before the plugin runs, short-circuiting the walk. The plugin still installs via the `version:` property; the `.nvmrc` is only there to satisfy nvm's directory walk, so this is a CI-harness fix with no change to the plugin. Proven green by build 116 (PR #29 experiment). --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mokagio
added a commit
that referenced
this pull request
Jul 2, 2026
The explicit-version Windows jobs hang and get killed (`0xC000013A`): with no `.nvmrc` in the working directory, nvm v0.39.4's ancestor walk loops forever under the Windows agent's bash. Setting `NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSION` makes the repo `pre-command` hook write one before the plugin runs, short-circuiting the walk. The plugin still installs via the `version:` property; the `.nvmrc` is only there to satisfy nvm's directory walk, so this is a CI-harness fix with no change to the plugin. Proven green by build 116 (PR #29 experiment). --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment (not for merge)
Confirms the verified root cause: the explicit-version Windows jobs hang because no
.nvmrcis in the working directory. Build 104 only passed because a.nvmrcwas committed at the repo root then; removing it (correctly) exposed the hang on theversion:-property path.This adds
NVM_BUILDKITE_PLUGIN_TEST_NVMRC_VERSIONto the existing hanging explicit-version jobs so the repo hook writes a.nvmrcbefore the plugin runs — the single variable separating 104 from 112–115.Expected: both
v20.19.5andv24.15.0Windows jobs pass. If so,.nvmrcpresence is the gate, and the real bug isnvm install <explicit version>hanging on Windows when no.nvmrcis in the directory tree.🤖 Generated with Claude Code