AI Launchpad: first-pass design-feedback fixes (DSGCOM-678)#50088
Merged
Conversation
The model could pick both write_3_posts and first_post_published, which read as duplicates in the same list (DSGCOM-678). Remove write_3_posts from the prompt's TASK_MENU so it's no longer offered; the menu stays a subset of the catalog (AI_Launchpad_Task_Menu_Test still passes).
Design feedback (DSGCOM-678): "Connect your social media accounts" read too specific (e.g. naming Instagram/Pinterest) when we do not know which platforms the user uses. Add a prompt rule so connect_social_media / drive_traffic / post_sharing_enabled subtitles stay about growing the audience and engaging visitors, without naming specific networks.
Design feedback (DSGCOM-678): the Educate and Portfolio descriptions did not extend across the container on mobile. `text-wrap: balance` evens line lengths, which keeps the copy narrow on the full-width single-column mobile cards. Scope balance to the two-column desktop grid and use `text-wrap: pretty` on mobile so longer copy fills the width while still avoiding orphans.
Design feedback (DSGCOM-678): use WPDS icons for the task states. Replace the inline hand-rolled SVGs with @wordpress/icons `border` (a dashed ring) for an active/not-started task and `published` (a check-in-circle) for a done one. Icons fill from currentColor so the existing grey toning still applies.
… time) Design feedback (DSGCOM-678): only one task card should be open at a time, and opening a different card should collapse the active one. Replace the cards uncontrolled defaultOpen with parent-controlled open/onOpenChange: a single openId state means opening any card closes the rest, and the user can still collapse all. The first incomplete card auto-opens once (guarded by a ref so a fully-collapsed list is never force-reopened). firstIncompleteIndex becomes nextIncompleteId (id-based, null when all complete).
Design feedback (DSGCOM-678): skipping a task should expand the next one. handleSkip now advances the accordion to the next incomplete task (via a new nextIncompleteId afterId overload that walks past the skipped id, falling back to any remaining incomplete task). Apply the same advance to handleMarkComplete so completing the open card does not leave the whole list collapsed.
…view Design feedback (DSGCOM-678): keep the preview thumbnail as a quick link into the site editor. The REST site payload returns edit_url and SitePreview renders the thumbnail as a link with a hover "Edit site" overlay. Block themes point at the Site Editor (site-editor.php); classic themes, which cannot use it, fall back to the Customizer (customize.php) so the quick link is always available.
Comments-only cleanup across the feature: remove the internal ticket references from code comments, collapse multi-paragraph docblocks and decision-narration to terse one-line summaries, and delete inline comments that just restated the code. Lint-required docblock tags (@param/@return/@Package) are preserved; no code, logic, or behavior changes.
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
Bot
added
[mu wpcom Feature] Ai Launchpad
[Package] Jetpack mu wpcom
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 21 files. Only the first 5 are listed here.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
Copons
added
the
I don't care about code coverage for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Implements the first pass of design feedback for the AI Launchpad (DSGCOM-678). The feature stays OFF in production (gated); these are UI/UX and copy fixes plus a comments-only cleanup.
Proposed changes
@wordpress/iconsborder(active) andpublished(done).write_3_posts— removed from the tailoring menu (redundant with "Write your first post").Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
The feature is gated off in production. On a paid WordPress.com (Simple or Atomic) test site with the AI Launchpad enabled: