Skip to content

Premium Analytics: keep widget-dashboard story settings drawer on-screen #50070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chihsuan merged 1 commit into from
Jul 1, 2026
Merged

Premium Analytics: keep widget-dashboard story settings drawer on-screen #50070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/premium-analytics/changelog/fix-widget-dashboard-story-settings-drawer
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Keep the widget-dashboard Storybook story's settings drawer on-screen when the dashboard is wider than the preview canvas.
42 changes: 27 additions & 15 deletions projects/packages/premium-analytics/widgets/stories/widget-dashboard-with-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,21 +171,33 @@ export function WidgetDashboardWithWidget( {
return (
<GlobalErrorProvider>
<HostRootFontSize hostEnvironment={ hostEnvironment }>
<div style={ { width: dashboardWidth, maxWidth: '100%' } }>
<WidgetDashboard
layout={ layout }
onLayoutChange={ setLayout }
widgetTypes={ [ storyWidgetType ] }
resolveWidgetModule={ resolveWidgetModule }
gridSettings={ { model: 'grid', rowHeight } }
editMode={ currentEditMode }
onEditChange={ setCurrentEditMode }
>
<Page title={ pageTitle } actions={ <WidgetDashboard.Actions /> } hasPadding>
<WidgetDashboard.NoWidgetsState />
<WidgetDashboard.Widgets />
</Page>
</WidgetDashboard>
{ /*
* Outer box fills the canvas and owns horizontal overflow; the inner
* box holds the simulated `dashboardWidth`. The host widget-settings
* drawer is portaled to <body> and positioned `fixed; right: 0`, so a
* body wider than the visible canvas (which a fixed `dashboardWidth`
* wider than the Storybook preview would cause) pushes the drawer
* off-screen. Containing the overflow here keeps the document at canvas
* width so the drawer stays anchored to the visible viewport edge; the
* wide layout remains inspectable by scrolling the box.
*/ }
<div style={ { width: '100%', overflowX: 'auto' } }>
<div style={ { width: dashboardWidth } }>
<WidgetDashboard
layout={ layout }
onLayoutChange={ setLayout }
widgetTypes={ [ storyWidgetType ] }
resolveWidgetModule={ resolveWidgetModule }
gridSettings={ { model: 'grid', rowHeight } }
editMode={ currentEditMode }
onEditChange={ setCurrentEditMode }
>
<Page title={ pageTitle } actions={ <WidgetDashboard.Actions /> } hasPadding>
<WidgetDashboard.NoWidgetsState />
<WidgetDashboard.Widgets />
</Page>
</WidgetDashboard>
</div>
</div>
</HostRootFontSize>
</GlobalErrorProvider>
Expand Down
Loading