Add feature-flagged Jetpack admin menu customization#50066
Open
DevinWalker wants to merge 12 commits into
Open
Add feature-flagged Jetpack admin menu customization#50066DevinWalker wants to merge 12 commits into
DevinWalker wants to merge 12 commits into
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
…omizable-admin-menu # Conflicts: # projects/packages/admin-ui/src/class-admin-menu.php # projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/tab-content.tsx
Contributor
| Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JETPACK-1798
Proposed changes
admin-ui, including recommended grouped defaults, site defaults, user preferences, and rollout filters.Customizetab that uses WordPress-native controls to toggle the recommended menu, rename terse group labels, reorder/group/hide menu items, and save site or personal preferences.Settingspinned as the last normal Jetpack submenu item, withActivity Logabove it and theUpgradeCTA still appended below when present.Related product discussion/links
Does this pull request change what data or activity we track or use?
No tracking changes.
Testing instructions
edit_posts, verify Products remains hidden, Customize is available, and only personal menu preferences can be saved.Verified locally after the trunk merge:
Notes:
--no-verifybecause the local Husky hook used an incompatible pnpm from the Codex runtime, while the Dockerized Jetpack verification above passed.