Skip to content

Forms: add awaiting-mod class to Jetpack menu feedback unread counter badge #50060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enejb wants to merge 4 commits into
base: trunk
Choose a base branch
from
+20 −7
Open

Forms: add awaiting-mod class to Jetpack menu feedback unread counter badge #50060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e07c0b3
Boost: add awaiting-mod class to admin menu counter for standard WP s…
enejb Jun 30, 2026
7ff4930
Revert "Boost: add awaiting-mod class to admin menu counter for stand…
enejb Jun 30, 2026
0b61211
Forms: add awaiting-mod class to feedback unread counter badge for st…
enejb Jun 30, 2026
9e4ace2
Forms: build unread-count badge markup with sprintf
enejb Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-jetpack-counter
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Add the awaiting-mod CSS class to the Jetpack menu feedback unread counter badge so it renders with the standard WordPress menu bubble styling.
23 changes: 16 additions & 7 deletions projects/packages/forms/src/contact-form/class-contact-form-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,7 +1556,8 @@ public function unread_count() {
if ( $unread > 0 ) {
$jetpack_unread_tag = $this->get_unread_count_badge_markup(
$jetpack_badge_count,
$jetpack_badge_count - $unread
$jetpack_badge_count - $unread,
'awaiting-mod'
);

// phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited
Expand Down Expand Up @@ -1591,16 +1592,24 @@ public function unread_count() {
*
* @param int $count Badge count to display.
* @param int|null $unread_diff Optional diff for combined Jetpack menu badges.
* @param string $extra_classes Optional additional CSS classes for the badge.
* @return string Badge HTML.
*/
private function get_unread_count_badge_markup( $count, $unread_diff = null ) {
$attributes = "class='menu-counter jp-feedback-unread-counter count-" . (int) $count . "'";
private function get_unread_count_badge_markup( $count, $unread_diff = null, $extra_classes = '' ) {
$classes = trim(
$extra_classes . ' menu-counter jp-feedback-unread-counter count-' . (int) $count
);

if ( null !== $unread_diff ) {
$attributes = "data-unread-diff='" . (int) $unread_diff . "' " . $attributes;
}
$data_attr = null !== $unread_diff
? sprintf( " data-unread-diff='%d'", (int) $unread_diff )
: '';

return " <span {$attributes}><span class='count'>" . number_format_i18n( $count ) . '</span></span>';
return sprintf(
" <span%s class='%s'><span class='count'>%s</span></span>",
$data_attr,
esc_attr( $classes ),
number_format_i18n( $count )
);
}

/**
Expand Down
Loading