Skip to content

Fix runtime dependency parity data targets #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Jul 3, 2026
Merged

Fix runtime dependency parity data targets #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion php-transformer/src/ArtifactCompiler/RuntimeDependencyParityReport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,20 @@ private function withRuntimeIslandTargets(array $targets, array $runtimeIslands)
$targets['classes'][$class] = true;
}
}

$tag = is_string($island['tag'] ?? null) ? strtolower(trim($island['tag'])) : '';
foreach ( $attributes as $name => $value ) {
$attributeName = strtolower((string) $name);
if ( ! str_starts_with($attributeName, 'data-') || ! preg_match('/^data-[a-z][a-z0-9_-]*$/', $attributeName) ) {
continue;
}

$attributeSelector = '[' . $attributeName . ']';
$targets['selectors'][$attributeSelector] = true;
if ( '' !== $tag ) {
$targets['selectors'][$tag . $attributeSelector] = true;
}
}
}

return $targets;
Expand Down Expand Up @@ -1175,7 +1189,7 @@ private function targetExists(array $dependency, array $targets): bool
private function scriptKind(string $path, string $script): string
{
$haystack = strtolower($path . "\n" . substr($script, 0, 2000));
if ( str_contains($haystack, 'netlify') || str_contains($haystack, 'rum') || str_contains($haystack, 'analytics') || str_contains($haystack, 'gtag') ) {
if ( preg_match('#(?:netlify|analytics|gtag|\brum\b|[-_./]rum[-_./])#', $haystack) ) {
return 'telemetry';
}

Expand Down
27 changes: 27 additions & 0 deletions php-transformer/tests/contract/run.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1713,6 +1713,7 @@ public function match(DOMElement $element, PatternContext $context): ?array
$assert(true === ($expandedRuntimeDependencies['canvas.preview']['canvas_api'] ?? null), 'compound canvas selector records canvas API usage');
$assert(str_contains($expandedRuntimeMarkup, '<canvas class="preview" aria-label="Preview"></canvas>'), 'compound canvas selector preserves canvas markup');
$assert(str_contains($expandedRuntimeMarkup, 'data-tool'), 'data attribute runtime selector remains addressable in generated markup');
$assert(true === ($expandedRuntimeDependencies['[data-tool]']['source_present'] ?? null), 'data attribute runtime selector is recorded as present in source markup');
$assert(str_contains($expandedRuntimeMarkup, 'mounted-app'), 'app root receiving appended children remains addressable in generated markup');
$assert(array() === ($expandedRuntimeReport['findings'] ?? array()), 'expanded runtime target selectors do not emit missing-target findings');

Expand Down Expand Up @@ -1774,6 +1775,32 @@ public function match(DOMElement $element, PatternContext $context): ?array
'runtime dependency parity does not fail entry output for selectors absent from that entry source'
);

$sharedDrumScriptSite = $compiler->compile(
array(
'entrypoint' => 'index.html',
'files' => array(
'index.html' => '<main><h1>Drum machine</h1><script src="js/site.js"></script></main>',
'patterns.html' => '<main><button data-voice-demo="kick">Kick</button><button data-groove="classic">Classic</button><script src="js/site.js"></script></main>',
'js/site.js' => 'document.querySelectorAll("[data-groove], [data-voice-demo]"); document.querySelectorAll(".is-playing").forEach(function (button) { button.classList.remove("is-playing"); });',
),
)
)->toArray();
$sharedDrumScriptReport = $sharedDrumScriptSite['source_reports']['runtime_dependency_parity'] ?? array();
$sharedDrumDependencies = $sharedDrumScriptReport['dependencies'] ?? array();
$sharedDrumDependency = array_values(array_filter($sharedDrumDependencies, static fn (array $dependency): bool => '[data-voice-demo]' === ($dependency['selector'] ?? '')))[0] ?? null;
$assert(
null !== $sharedDrumDependency,
'runtime dependency parity records shared data-attribute selectors absent from the entry source'
);
$assert(
'first_party' === ($sharedDrumDependency['script_kind'] ?? ''),
'runtime dependency parity does not classify drum scripts as RUM telemetry'
);
$assert(
array() === array_values(array_filter($sharedDrumScriptReport['findings'] ?? array(), static fn (array $finding): bool => in_array($finding['selector'] ?? '', array('.is-playing', '[data-voice-demo]', '[data-groove]'), true))),
'runtime dependency parity does not fail entry output for shared drum script selectors absent from that entry source'
);

$hamburgerOverlaySite = $compiler->compile(
array(
'entrypoint' => 'index.html',
Expand Down
Loading