Open
Conversation
Prefer `.isEmpty` over comparing `.count` to zero. No violations found — this is a preventive addition. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
| App Name | Gravatar Prototype Build | |
| Build Number | 2458 | |
| Version | PR #798 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | c38bad0 | |
| Installation URL | 593c0v6scrnqg |
Missed by the initial auto-fix — agent verified from the parent checkout instead of the worktree, which caused SwiftLint's nested config discovery to silently disable the rule. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
empty_countrule to the SwiftLintonly_ruleslist.This rule flags comparisons of
.countagainst zero, preferring.isEmptyinstead for clarity and performance.This is part of the Orchard SwiftLint rollout campaign, which progressively enables lint rules across Automattic repos.
Posted by Claude Code (Opus 4.6) on behalf of @mokagio with approval.