Integrate doctests pipeline into CI#168
Open
rgwohlbold wants to merge 17 commits into
Open
Conversation
| push: | ||
| branches: [master, rewrite-2023, staging, trying] | ||
| # TODO: remove ci-doctests from here | ||
| branches: [master, rewrite-2023, staging, trying, ci-doctests] |
There was a problem hiding this comment.
I don't completely understand. Why do we need a ci-doctests branch? I thought we would always run the doctests when we add commits to rewrite-2023? Or is this exactly what your TODO comments mean?
Author
There was a problem hiding this comment.
Yeah, that's what I tried to express in the TODO. I left the ci-doctests branch in there so that if there are any changes to the PR, the job is rerun. Otherwise, we should remove it from the yaml
rgwohlbold
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
.github/workflows/test.yml