Skip to content

Rustfmt#16

Closed
tillarnold wants to merge 6 commits into
Aurel300:rewrite-2023from
tillarnold:rustfmt
Closed

Rustfmt#16
tillarnold wants to merge 6 commits into
Aurel300:rewrite-2023from
tillarnold:rustfmt

Conversation

@tillarnold
Copy link
Copy Markdown

@tillarnold tillarnold commented Nov 2, 2023

Builds on top of #15. To see what changed since #15 see https://github.com/tillarnold/prusti-dev/compare/till_rebuilt_3..tillarnold:prusti-dev:rustfmt

Run rustfmt on the entire project.

I did this by running cargo fmt in the repo root as well as in prusti-contracts as that appears to be a different workspace. Running ./x.py fmt-all resulted in an error. Old prusti recently merged a PR that changed how the formatting in x.py works viperproject#1456. Maybe that fix could be relevant here too?

@JonasAlaif
Copy link
Copy Markdown
Collaborator

Let's only run cargo fmt on code that is specifically in this repo (i.e. prust-encoder and the like). If we format everything then it will cause conflicts when we try to merge in work from other branches for the other directories.

@JonasAlaif
Copy link
Copy Markdown
Collaborator

Also we need to only do this after #11 to avoid conflicts with that

@tillarnold tillarnold mentioned this pull request Nov 7, 2023
2 tasks
@tillarnold tillarnold closed this Nov 10, 2023
@tillarnold tillarnold mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants