Disambiguate adt names#156
Open
Trzyq0712 wants to merge 3 commits into
Open
Conversation
Aurel300
reviewed
Mar 19, 2026
Collaborator
|
I'm not such a big fan of this since it'll make the Viper program virtually unreadable (even more so than it already is), even for small programs. Any solution that does this would need to use the simple name if there is no conflict and the complex name otherwise. Alternatively, to be able to toggle this under a configuration flag. Note that you could probably replace your implementation with rustc's debug formatting for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #155.
Problem
Using base names for types caused
ConsistencyErrorcollisions in the VIPER backend, notably for:std::ascii::EscapeDefaultvs.std::char::EscapeDefault.struct Bardefinitions in different scopes of the same function.Solution
$$.disambiguator(using$) when it is non-zero.Example Output:
0$$core$$ascii$$EscapeDefault0$$main$$Barvs.0$$main$$Bar$1