Proper encoding of uninhabited types (WIP)#107
Merged
Conversation
Aurel300
reviewed
Oct 3, 2025
| let fields = self.fields.iter().zip(other.fields.iter()); | ||
| StructData { | ||
| data: (&self.data, &other.data), | ||
| inhabited: self.inhabited || other.inhabited, |
Owner
There was a problem hiding this comment.
I think zip should always combine two different representations of the same type (@JonasAlaif correct me if I'm wrong), so this should rather be an assertion that the two values are equal, like the one for the number of fields at the beginning of this function.
Aurel300
force-pushed
the
zgrannan/uninhabited
branch
from
b8f087c to
c875dfb
Compare
Aurel300
reviewed
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to clean this up a bit but it appears to work.
This builds on top of #106 which should be merged first
139 failed; 142 passed (+10 compared to #106)