Skip to content

feat: update contact form to use npm package#698

Open
sifterstudios wants to merge 11 commits intomainfrom
feat/update-contact-form-to-use-npm-package
Open

feat: update contact form to use npm package#698
sifterstudios wants to merge 11 commits intomainfrom
feat/update-contact-form-to-use-npm-package

Conversation

@sifterstudios
Copy link
Collaborator

image

this PR transfers the contact-form from being embedded in planner-web to being imported from @mrfylke/contact-form. Has been tested locally, looks to have identical functionality.

Would appreciate some new eyes on this and advice on testing the submit call with e2e testing.

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
planner-web Ready Ready Preview, Comment Feb 20, 2026 2:57pm

Request Review

@rosvik
Copy link
Member

rosvik commented Feb 23, 2026

Hey, nice to have you here @sifterstudios! Deleting 11k lines of code is certainly one way to make an entrance 🔥

Is the source code of @mrfylke/contact-form made public anywhere? Should it be?

@sifterstudios
Copy link
Collaborator Author

Hey, nice to have you here @sifterstudios! Deleting 11k lines of code is certainly one way to make an entrance 🔥

Is the source code of @mrfylke/contact-form made public anywhere? Should it be?

Hello, hello! 🔥🌪️
Yes, moving source code into npm packages is a great way of deleting code lines 😅!

@mrfylke/contact-form will be moved into a repo here at @atb-as to simplify deployment. There's no need for it to be private, as it's original code from planner-web, and the npm package is public with the same EUPL 1.2 license. 😄

@sifterstudios
Copy link
Collaborator Author

Update @rosvik - repo moved here: https://github.com/atb-AS/mrfylke-contact-form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants