Skip to content

feat: Refactor use non-transit trips with useQuery and align with trips#5856

Merged
marius-at-atb merged 9 commits intomasterfrom
marius/refactor-non-transit-trips-query
Mar 10, 2026
Merged

feat: Refactor use non-transit trips with useQuery and align with trips#5856
marius-at-atb merged 9 commits intomasterfrom
marius/refactor-non-transit-trips-query

Conversation

@marius-at-atb
Copy link
Copy Markdown
Collaborator

@marius-at-atb marius-at-atb commented Mar 4, 2026

Issue Reference

Resolves https://github.com/AtB-AS/kundevendt/issues/22947

Description

Aligns transit and non-transit trips searches.

Also includes a fix for "flickering" of search results: caae586

@marius-at-atb marius-at-atb self-assigned this Mar 4, 2026
@marius-at-atb marius-at-atb marked this pull request as ready for review March 5, 2026 15:29
signal,
}),
enabled: isNonTransitTripSearchEnabled,
staleTime: 30 * ONE_MINUTE_MS,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed, and default to 0?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but I just had a closer look.
Here we don't want to trigger new requests if you just go back and forth quickly between a details screen and the results screen. Also the now time will be updated at "reasonable times", so tripsProps will trigger queryKey changes anyway.

@marius-at-atb marius-at-atb merged commit 153085d into master Mar 10, 2026
7 checks passed
@marius-at-atb marius-at-atb deleted the marius/refactor-non-transit-trips-query branch March 10, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants