Simplify public facing compiler API, enable custom protoc executable - #180
Merged
Conversation
menduz
force-pushed
the
fix-dependency-graph-readme
branch
from
June 15, 2026 23:20
469a8e4 to
138f1fc
Compare
menduz
changed the title
Arwalk
approved these changes
Jun 16, 2026
Arwalk
left a comment
Arwalk
left a comment
Owner
There was a problem hiding this comment.
Dis gud.
Side note: i had https://github.com/zig-protobuf/zig-protoc working at some point, i should get back into it to propose compiled on the spot protoc.
Collaborator
Author
|
We do compile it on the spot in the conformance tests if you want to revamp it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies and fixes the public facing API for build.zig, we were using a wrong owner and that broke the README example.
Hardly used fields were removed in favor of passing
LazyPath("protoc")which I consider more useful for people that 1) do not want to use google's 2) there are no prebuilt binaries (BSD)I think this PR can also be enough to close #173