Skip to content

fix(ci): use explicit path for Dockerfile.registry in build-push action - #125

Merged
Arenukvern merged 2 commits into
mainfrom
fix/registry-dockerfile-path
Aug 22, 2026
Merged

fix(ci): use explicit path for Dockerfile.registry in build-push action#125
Arenukvern merged 2 commits into
mainfrom
fix/registry-dockerfile-path

Conversation

@Arenukvern

@Arenukvern Arenukvern commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • The Publish MCP Registry server workflow failed (run #1) with:
    buildx failed to solve: failed to read dockerfile: open Dockerfile.registry: no such file or directory
  • Root cause: docker/build-push-action resolves a relative file: input against the workspace root, not the context directory. The Dockerfile lives at mcp_server_dart/Dockerfile.registry.
  • Fix: make the path explicit — file: mcp_server_dart/Dockerfile.registry.

Testing

  • Workflow-only change; verified the file exists in git at the referenced path. The next publish run will exercise the fix.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the Docker image build configuration for registry publishing.

buildx resolves a relative 'file:' input against the workspace root,
not the build context, so the publish workflow failed with
'open Dockerfile.registry: no such file or directory'.
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e59afbf-71d3-4b4c-9b4b-8069586b9a98

📥 Commits

Reviewing files that changed from the base of the PR and between 077e105 and 7cb7b67.

📒 Files selected for processing (1)
  • .github/workflows/publish_mcp_registry.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The registry publishing workflow now uses mcp_server_dart/Dockerfile.registry for the Docker image build.

Changes

Registry Docker Build

Layer / File(s) Summary
Update registry Dockerfile path
.github/workflows/publish_mcp_registry.yml
The Docker build step now references mcp_server_dart/Dockerfile.registry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7cb7b

This change corrects the Dockerfile path used by the publish workflow; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the failure, root cause, fix, and testing, but it omits the required Validation and Contributor Checklist sections. Add the required Validation and Contributor Checklist sections, and record the applicable command results and checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the workflow fix and the explicit Dockerfile path change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/registry-dockerfile-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Arenukvern
Arenukvern merged commit b3c8310 into main Aug 22, 2026
12 checks passed
@Arenukvern
Arenukvern deleted the fix/registry-dockerfile-path branch August 22, 2026 18:00
@Arenukvern

Copy link
Copy Markdown
Owner Author

Added a second fix in 73dc88e: the auto-sync-versions job was failing on release PRs because sync_version.sh now rewrites docs.json (variables.version) but the workflow's git add list didn't include it — so git commit ran with nothing staged and exited 1. Staged docs.json in both the automatic step and the manual checklist instructions.

@Arenukvern

Copy link
Copy Markdown
Owner Author

Reverted 73dc88e in 6d5dd3e — the docs.json staging fix belongs on the release PR branch (#126), not main. It's been pushed directly to release-please--branches--main--components--flutter-mcp-toolkit (c18b47c) so the sync job can pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant