fix(frontend): use fill layout for join tournament banner image#413
Merged
Hydrax117 merged 2 commits intoJun 1, 2026
Merged
Conversation
Reserve banner space with a positioned h-48 container and Next.js Image fill + sizes so the join page avoids CLS and build warnings. Closes Arenax-gaming#365 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@Joewizy is attempting to deploy a commit to the paul joseph's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Joewizy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imagewithfillinside a fixedh-48container so layout space is reserved before load (no CLS).sizesfor the single-column join layout (max-w-lg).tournament.bannerwhen provided by the API, with a deterministic fallback image.Closes #365
Test plan
/tournaments/[id]/joinfor an open tournament and confirm the banner renders at 192px height without layout shift on load.npm run buildinfrontendand confirm no Next.js Image width/height warnings for the join page.