Skip to content

Conversation

@vituri
Copy link

@vituri vituri commented Apr 18, 2025

Fixes #137

This PR was an experiment using Copilot. See our knowledge base for more details.

Description

  • Fixed an issue where plots and cards were not fillable when using shiny.router with bslib::page_fillable. A fill argument was added to router_ui to control whether fill classes are added.
  • Fixed errors in tests by ensuring js_file and css_file are defined within the router_ui function scope.

@vituri vituri marked this pull request as ready for review April 18, 2025 20:02
@yoelii
Copy link

yoelii commented Jun 5, 2025

Hello,

When the pull request will be approuved and available ?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: plotly inside router does not fill the page when used inside bslib::page_fillable

3 participants