fix(dashboard): use 'name' instead of 'title' in session.create() to fix PrismaClientValidationError when df:name capability is set#2055
Open
ashish-solankar wants to merge 1 commit into
Conversation
…fix PrismaClientValidationError when df:name capability is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #2054
When the
df:namecapability is set (e.g.'df:name': 'Login Test'), session creation crashes with:The session is never created. Removing
df:nameis the only workaround.Root Cause
In
src/dashboard/event-manager.ts, theonSessionStartedmethod builds thecreateOptionsobject using the keytitleto store the session name from thedf:namecapability:The Prisma
Sessionmodel inprisma/schema.prismahas notitlefield — the correct field isname:When
df:nameis not set,titleisundefinedand Prisma silently ignores the unknown key — so sessions work fine. Whendf:namehas a value, Prisma's strict input validation fires, sees the unknowntitlefield, and rejects the entirecreateOptionsobject — including the validbuildIdfield — which explains the misleading error message pointing atbuildId.Fix
Single one-line change in
src/dashboard/event-manager.ts— renametitle→namein thecreateOptionsobject:Steps to Reproduce
enableDashboard: true)'df:name': 'Login Test'(along withdf:build) in your test capabilitiesPrismaClientValidationError: Unknown argument 'buildId'Testing
df:nameis setdf:namecontinue to work unchangeddf:build,df:accesskey,df:tokenall continue to work as before