-
Couldn't load subscription status.
- Fork 24
feat: bump package versions, and fix issues #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
magrinj
wants to merge
1
commit into
AppAndFlow:main
Choose a base branch
from
magrinj:feat/support-new-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25,041
−19,351
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| name: 🐛 Bug report | ||
| description: Report a reproducible bug or regression in this library. | ||
| labels: [bug] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| # Bug report | ||
| 👋 Hi! | ||
| **Please fill the following carefully before opening a new issue ❗** | ||
| *(Your issue may be closed if it doesn't provide the required pieces of information)* | ||
| - type: checkboxes | ||
| attributes: | ||
| label: Before submitting a new issue | ||
| description: Please perform simple checks first. | ||
| options: | ||
| - label: I tested using the latest version of the library, as the bug might be already fixed. | ||
| required: true | ||
| - label: I tested using a [supported version](https://github.com/reactwg/react-native-releases/blob/main/docs/support.md) of react native. | ||
| required: true | ||
| - label: I checked for possible duplicate issues, with possible answers. | ||
| required: true | ||
| - type: textarea | ||
| id: summary | ||
| attributes: | ||
| label: Bug summary | ||
| description: | | ||
| Provide a clear and concise description of what the bug is. | ||
| If needed, you can also provide other samples: error messages / stack traces, screenshots, gifs, etc. | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: library-version | ||
| attributes: | ||
| label: Library version | ||
| description: What version of the library are you using? | ||
| placeholder: "x.x.x" | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: react-native-info | ||
| attributes: | ||
| label: Environment info | ||
| description: Run `react-native info` in your terminal and paste the results here. | ||
| render: shell | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: steps-to-reproduce | ||
| attributes: | ||
| label: Steps to reproduce | ||
| description: | | ||
| You must provide a clear list of steps and code to reproduce the problem. | ||
| value: | | ||
| 1. … | ||
| 2. … | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: reproducible-example | ||
| attributes: | ||
| label: Reproducible example repository | ||
| description: Please provide a link to a repository on GitHub with a reproducible example. | ||
| validations: | ||
| required: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| blank_issues_enabled: false | ||
| contact_links: | ||
| - name: Feature Request 💡 | ||
| url: https://github.com/AppAndFlow/react-navigation-bottom-sheet/discussions/new?category=ideas | ||
| about: If you have a feature request, please create a new discussion on GitHub. | ||
| - name: Discussions on GitHub 💬 | ||
| url: https://github.com/AppAndFlow/react-navigation-bottom-sheet/discussions | ||
| about: If this library works as promised but you need help, please ask questions there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Setup | ||
| description: Setup Node.js and install dependencies | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: .nvmrc | ||
|
|
||
| - name: Restore dependencies | ||
| id: yarn-cache | ||
| uses: actions/cache/restore@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3 | ||
| with: | ||
| path: | | ||
| **/node_modules | ||
| .yarn/install-state.gz | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/package.json', '!node_modules/**') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }} | ||
| ${{ runner.os }}-yarn- | ||
|
|
||
| - name: Install dependencies | ||
| if: steps.yarn-cache.outputs.cache-hit != 'true' | ||
| run: yarn install --immutable | ||
| shell: bash | ||
|
|
||
| - name: Cache dependencies | ||
| if: steps.yarn-cache.outputs.cache-hit != 'true' | ||
| uses: actions/cache/save@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3 | ||
| with: | ||
| path: | | ||
| **/node_modules | ||
| .yarn/install-state.gz | ||
| key: ${{ steps.yarn-cache.outputs.cache-primary-key }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| name: CI | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| merge_group: | ||
| types: | ||
| - checks_requested | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Lint files | ||
| run: yarn lint | ||
|
|
||
| - name: Typecheck files | ||
| run: yarn typecheck | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Run unit tests | ||
| run: yarn test --maxWorkers=2 --coverage | ||
|
|
||
| build-library: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Build package | ||
| run: yarn prepare | ||
|
|
||
| build-web: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Build example for Web | ||
| run: | | ||
| yarn example expo export --platform web |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| v22.20.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| nodeLinker: node-modules | ||
| nmHoistingLimits: workspaces | ||
|
|
||
| plugins: | ||
| - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs | ||
| spec: "@yarnpkg/plugin-interactive-tools" | ||
| - path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs | ||
| spec: "@yarnpkg/plugin-workspace-tools" | ||
|
|
||
| yarnPath: .yarn/releases/yarn-3.6.1.cjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,12 @@ | ||
| module.exports = { | ||
| presets: ['module:metro-react-native-babel-preset'], | ||
| overrides: [ | ||
| { | ||
| exclude: /\/node_modules\//, | ||
| presets: ['module:react-native-builder-bob/babel-preset'], | ||
| }, | ||
| { | ||
| include: /\/node_modules\//, | ||
| presets: ['module:@react-native/babel-preset'], | ||
| }, | ||
| ], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { fixupConfigRules } from '@eslint/compat'; | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import js from '@eslint/js'; | ||
| import prettier from 'eslint-plugin-prettier'; | ||
| import { defineConfig } from 'eslint/config'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = path.dirname(__filename); | ||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| recommendedConfig: js.configs.recommended, | ||
| allConfig: js.configs.all, | ||
| }); | ||
|
|
||
| export default defineConfig([ | ||
| { | ||
| extends: fixupConfigRules(compat.extends('@react-native', 'prettier')), | ||
| plugins: { prettier }, | ||
| rules: { | ||
| 'react/react-in-jsx-scope': 'off', | ||
| 'prettier/prettier': 'error', | ||
| }, | ||
| }, | ||
| { | ||
| ignores: ['node_modules/', 'lib/'], | ||
| }, | ||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,32 @@ | ||
| { | ||
| "name": "@th3rdwave/react-navigation-bottom-sheet-example", | ||
| "displayName": "ReactNavigationBottomSheet Example", | ||
| "expo": { | ||
| "name": "@th3rdwave/react-navigation-bottom-sheet-example", | ||
| "slug": "th3rdwave-react-navigation-bottom-sheet-example", | ||
| "description": "Example app for @th3rdwave/react-navigation-bottom-sheet", | ||
| "privacy": "public", | ||
| "version": "1.0.0", | ||
| "platforms": [ | ||
| "ios", | ||
| "android", | ||
| "web" | ||
| ], | ||
| "orientation": "portrait", | ||
| "icon": "./assets/icon.png", | ||
| "userInterfaceStyle": "light", | ||
| "newArchEnabled": true, | ||
| "splash": { | ||
| "image": "./assets/splash-icon.png", | ||
| "resizeMode": "contain", | ||
| "backgroundColor": "#ffffff" | ||
| }, | ||
| "ios": { | ||
| "supportsTablet": true | ||
| "supportsTablet": true, | ||
| "bundleIdentifier": "testlibrary.example" | ||
| }, | ||
| "android": { | ||
| "adaptiveIcon": { | ||
| "foregroundImage": "./assets/adaptive-icon.png", | ||
| "backgroundColor": "#ffffff" | ||
| }, | ||
| "edgeToEdgeEnabled": true, | ||
| "package": "testlibrary.example" | ||
| }, | ||
| "assetBundlePatterns": [ | ||
| "**/*" | ||
| ] | ||
| "web": { | ||
| "favicon": "./assets/favicon.png" | ||
| } | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,16 @@ | ||
| const path = require('path'); | ||
| const pak = require('../package.json'); | ||
| const { getConfig } = require('react-native-builder-bob/babel-config'); | ||
| const pkg = require('../package.json'); | ||
|
|
||
| const root = path.resolve(__dirname, '..'); | ||
|
|
||
| module.exports = function (api) { | ||
| api.cache(true); | ||
|
|
||
| return { | ||
| presets: ['babel-preset-expo'], | ||
| plugins: [ | ||
| [ | ||
| 'module-resolver', | ||
| { | ||
| extensions: ['.tsx', '.ts', '.js', '.json'], | ||
| alias: { | ||
| // For development, we want to alias the library to the source | ||
| [pak.name]: path.join(__dirname, '..', pak.source), | ||
| }, | ||
| }, | ||
| ], | ||
| 'react-native-reanimated/plugin', | ||
| ], | ||
| }; | ||
| return getConfig( | ||
| { | ||
| presets: ['babel-preset-expo'], | ||
| }, | ||
| { root, pkg } | ||
| ); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine to me to add this github actions and templates, same one as
create-react-native-library, but if you don't want them tell me, and I'll remove this changes