Feature/create custom preset UI#607
Merged
malinduc-apadmi merged 15 commits intoJun 8, 2026
Merged
Conversation
Replace card-based layout with flat design using gray section headers Add syntax-highlighted JSON body editor (BasicTextField + TextFieldValue) Add custom status code chip dropdown with semantic colour coding Add segmented JSON/Plain Text body type toggle Inline char count and JSON validity indicator in Body header row Bound preset panel between top bar and logs (Column layout) Extract MiddleContentArea composable to fix ColumnScope.AnimatedVisibility ambiguity Remove rounded corner from preset panel overlay Add cancel/save header with progress indicator Add reformat param to buildHighlightedAnnotatedString for in-place highlighting Add missing i18n strings (cancel, endpointSubtitle, statusCodeRowLabel, etc.)
malinduc-apadmi
requested review from
SamC-Apadmi and
piriyas-code
and removed request for
SamC-Apadmi
SamC-Apadmi
requested changes
Jun 5, 2026
| // ── Middle content area (bounded: never spills into logs) ──── | ||
| // Extracted to its own composable so that ColumnScope is not an | ||
| // ambient implicit receiver — otherwise the compiler resolves | ||
| // AnimatedVisibility to ColumnScope.AnimatedVisibility and errors. |
Collaborator
There was a problem hiding this comment.
Not sure this comment is needed?
| val bodyTitle: String, | ||
| val bodyTypeJson: String, | ||
| val bodyTypePlain: String, | ||
| val bodyTypeXml: String, |
Collaborator
There was a problem hiding this comment.
Can we remove XML? Don't really want to support that
Collaborator
Author
There was a problem hiding this comment.
Resolved, removed from Enum
SamC-Apadmi
requested changes
Jun 5, 2026
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .background(MaterialTheme.colorScheme.surfaceContainerHigh) | ||
| .padding(horizontal = 16.dp, vertical = 14.dp), |
Collaborator
There was a problem hiding this comment.
We try to stick to multiples of 4 for padding, can this be 12 or 16?
Collaborator
Author
There was a problem hiding this comment.
Yes, Resolved
| State.Editing.ResponseType.PlainText, | ||
| State.Editing.ResponseType.Xml, | ||
| State.Editing.ResponseType.Html, | ||
| State.Editing.ResponseType.None, |
Collaborator
There was a problem hiding this comment.
can this not just use State.Editing.ResponseType.entries?
Collaborator
Author
There was a problem hiding this comment.
Good catch, of course can, the list was there to guard against Diktat reordering the enum alphabetically and breaking the UI order. Fixed by adding @Suppress("EnumEntryOrder") to the enum declaration so the order is owned by the enum itself, resolved switched to entries.
| Modifier | ||
| } | ||
| ) | ||
| .padding(horizontal = 14.dp, vertical = 8.dp), |
SamC-Apadmi
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigns the Create/Edit Preset panel with a clean flat layout, replacing the previous card-based approach.
Changes
UI / Layout
Flat panel with gray SectionLabel section headers (RESPONSE, HEADERS (N))
PanelHeader with bold title, endpoint subtitle, Cancel + Save buttons, and a slim progress indicator
Preset panel is now bounded between the top bar and the logs panel — no longer overlaps either
Removed rounded top-start corner from the preset panel overlay
Status Code
Custom StatusCodeDropdown with a StatusChip showing semantic colour coding (2xx = Ok/green, 3xx = Info, 4xx = Warn, 5xx = Err)
Dropdown wraps content, label left / control right (SpaceBetween)
Body
Segmented BodyTypeToggle (JSON / Plain Text) with teal selected state
JsonBodyTextField — BasicTextField + TextFieldValue with live JSON syntax highlighting via buildHighlightedAnnotatedString (reformat = false so typing is never interrupted)
Body header row shows char count + validity icon inline, both in primary (teal) colour
Headers
Existing headers displayed as inline key : value × rows (teal key, muted value)
Section label includes live count — HEADERS (1)
Add-header row: two single-line CustomTextField inputs with muted placeholder hints + teal + button
Architecture
Extracted MiddleContentArea composable to fix ColumnScope.AnimatedVisibility ambiguity
Added reformat: Boolean = true param to buildHighlightedAnnotatedString
Added onCancel to public CreateEditPresetWidget API
Added i18n strings: cancel, endpointSubtitle, statusCodeRowLabel, bodyTypeLabel, responseSectionLabel, bodyLabel
Testing
Build and run the desktop app
Open the Create Preset panel and verify: status code dropdown, body type toggle, JSON highlighting, header add/remove, cancel/save buttons, panel bounds (does not overlap top bar or logs)