Bump toast z-index to 1090 so toasts appear above modals #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/807 |
curtis-allan
approved these changes
Dec 5, 2025
Contributor
curtis-allan
left a comment
curtis-allan
left a comment
There was a problem hiding this comment.
Not sure how I haven't seen this conflict before, maybe they were really well hidden or I've just managed to avoid it all this time :/ Agree we'd want FastHTML toasts to take priority though so LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toasts were using
z-index: 1000, but UIkit modals (used by MonsterUI/FrankenUI) usez-index: 1010. This caused toasts to be hidden behind modals.Bumped to
z-index: 1090to ensure toasts always appear above modals while leaving room in the z-index scale for other elements.Related: AnswerDotAI/MonsterUI#148, AnswerDotAI/solveit#1071