Conversation
abdnh
previously approved these changes
Aug 21, 2026
r-lelis
previously approved these changes
Aug 21, 2026
r-lelis
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
The Step Deck tutorial could construct an OverlayTarget with a missing widget when findChild("AnkiHubSmartSearchButton") returned None during Browser lifecycle timing windows (or stale Browser references). Overlay positioning then attempted to read geometry (topLeft/bottomRight) from a missing target.
How to reproduce
Manually run Step Deck tutorial in Browser:
◦ Verify Smart Search step highlights correctly when button is present.
◦ Verify no crash if button is temporarily unavailable.
◦ Verify fallback step is visible and usable (no half-hidden top-left dialog).
** you can set the
return Noneon_get_smart_search_button_targetor you can turn off the smart search feature flag