Check if parent node is LocationNode#299
Open
houcem-soued wants to merge 1 commit intoAndrewHartAR:developfrom
Open
Check if parent node is LocationNode#299houcem-soued wants to merge 1 commit intoAndrewHartAR:developfrom
houcem-soued wants to merge 1 commit intoAndrewHartAR:developfrom
Conversation
…e locationNodeTouched(node:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When user clicks on a node, the function locationNodeTouched(node:) is not triggered, since a sub-node is registered as the firstHitTest node and the casting of that node to a LocationNode is failing.
Breaking Changes
The idea is to check if one of the parents of the selected node is a LocationNode and in that case we trigger locationNodeTouched(node:)
PR Checklist
open, andpublicscoped methods and properties.