Refactor application to be configuration-driven #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the entire application to follow the principles of 'Convention over Configuration' and 'Configuration over Code'. - All I-Ching data (trigrams, hexagrams, line meanings) has been moved out of the logic files and into centralized, well-structured configuration files in `src/config`. - The data models for hexagrams and lines have been enriched with detailed information and citations from authoritative sources. - The core `explanationProvider.js` has been refactored to be a generic component that assembles its output from these config files. - The test suite has been completely overhauled to validate the new architecture and a number of issues with the test environment have been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the entire application to follow the principles of 'Convention over Configuration' and 'Configuration over Code'.
src/config.explanationProvider.jshas been refactored to be a generic component that assembles its output from these config files.