Skip to content

Reduce unsafe usage with MaybeUninit::write #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andersk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce unsafe usage with MaybeUninit::write #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,13 +286,12 @@ impl<T: Send> ThreadLocal<T> {
// the local thread can access this value. The target location of the pointer
// is valid since it came from the UnsafeCell and a valid initialized value
// of type `T` is being written into the cell.
unsafe { value_ptr.write(MaybeUninit::new(data)) };
let data_ref = &*unsafe { &mut *value_ptr }.write(data);
entry.present.store(true, Ordering::Release);

self.values.fetch_add(1, Ordering::Release);

// SAFETY: The value was just initialized to the provided value.
unsafe { (&*value_ptr).assume_init_ref() }
data_ref
}

#[inline]
Expand Down