Task/2 3 2025 json schema for filters#1663
Draft
emily-howell wants to merge 7 commits intodevelopfrom
Draft
Conversation
… format. Also adding additional validator constructs needed to complete this.
…2025-json-schema-for-filters
Member
|
this approach looks nice and for the current cases it looks like less code to define the params. Q: How are surprises handled, and how does that compare to our older error messages? |
cyrush
reviewed
Mar 3, 2026
| conduit::Node &info); | ||
|
|
||
|
|
||
| static bool validate_node(const conduit::Node &schema, |
Member
There was a problem hiding this comment.
No need for static here, if we want them hidden we could use a detail namespace in the c++ file,but I think it is fine to have them here as well w/o static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a first pass and very much a draft version
Most focus was placed on building the actual structure. Before merging into an official version significant revisions to error handling in the validator should be made to add clarity.
This schema has currently only been added in
ascent_runtime_vtkh_filters. The goal is to implement this for all filters in Ascent. Once this has been done and the full scope of Json Schema features needed has been determined, theflow_schema_validatorshould be migrated to conduit.