unify uniform grid and sample filters#1661
Conversation
depts->deps
…ine-DAV/ascent into task/2025_03_warpx_unit_test
…ine-DAV/ascent into task/2025_03_warpx_unit_test
…ine-DAV/ascent into task/2025_03_warpx_unit_test
Initial ANARI development via VTKm/Viskores
remove this check for now while we test and decide how to design things. anari vs. anari_vol & anari_pseudo & anari_points(?) idk all their renderers
|
Q: If someone still has an actions file that uses |
No, my plan was to remove it as a standalone filter, but the args are the same. I need to update the docs and examples. |
|
I think it would be good to still support it. If the args are the same, "uniform_grid" can be added as an alias for "sample", we can do it with slight of hand. |
|
For our test cases, we should have at least one that uses filter type |
|
Looks good! See a few suggestions |
| else //not set; default min | ||
| { | ||
| x_min = g_bounds.X.Min; | ||
| x_min = min_b["x"].as_float64(); |
There was a problem hiding this comment.
lets use to_float64() to be safe (folks may pass ints)
| else | ||
| { | ||
| y_min = g_bounds.Y.Min; | ||
| y_min = min_b["y"].as_float64(); |
There was a problem hiding this comment.
| y_min = min_b["y"].as_float64(); | |
| y_min = min_b["y"].to_float64(); |
| else //not set; default min | ||
| { | ||
| x_min = g_bounds.X.Min; | ||
| x_min = min_b["x"].as_float64(); |
There was a problem hiding this comment.
| x_min = min_b["x"].as_float64(); | |
| x_min = min_b["x"].to_float64(); |
| else | ||
| { | ||
| z_min = g_bounds.Z.Min; | ||
| z_min = min_b["z"].as_float64(); |
There was a problem hiding this comment.
| z_min = min_b["z"].as_float64(); | |
| z_min = min_b["z"].to_float64(); |
| else | ||
| { | ||
| x_max = g_bounds.X.Max; | ||
| x_max = max_b["x"].as_float64(); |
There was a problem hiding this comment.
| x_max = max_b["x"].as_float64(); | |
| x_max = max_b["x"].to_float64(); |
| else | ||
| { | ||
| y_max = g_bounds.Y.Max; | ||
| y_max = max_b["y"].as_float64(); |
There was a problem hiding this comment.
| y_max = max_b["y"].as_float64(); | |
| y_max = max_b["y"].to_float64(); |
| else | ||
| { | ||
| z_max = g_bounds.Z.Max; | ||
| z_max = max_b["z"].as_float64(); |
There was a problem hiding this comment.
| z_max = max_b["z"].as_float64(); | |
| z_max = max_b["z"].to_float64(); |
2 participants
Add the uniform grid sampling filter into the larger sample filter (points, line, box).
Rename the viskoresProbe output field "HIDDEN" to "valid_mask"