Fixed TheGamesDB scraper by adding a document tree segment 'scrapers' to the config file#802
Fixed TheGamesDB scraper by adding a document tree segment 'scrapers' to the config file#802ocket8888 wants to merge 3 commits intoAloshi:masterfrom
Conversation
… to the config file This allows the user to pass an API key for the gamesdb scraper
|
I guess this shoulda been a draft :P |
|
Hi there, I'm currently the lead dev behind TGDB, just a small comment about this PR, we're not handing out keys to individual users, since we expect you to use the public key, since the key is limited per IP, so you can have as many users using it as you'd like. it also allows us some basic statistics on how and by which project the requests are made. Note, public key doesn't need to be obscured, since we don't expect malicious use, nor do we have an hard to meet requirement to obtain one. P.S, Ideally the project owner would use their own key, but that's not set in stone. |
|
Unfortunately I think the project owner has left this project. Good to hear that I can just put my public key in there, thanks for letting me know. |
ViewController: improves bulk removal of entries
This allows the user to pass an API key for the gamesdb scraper. It works by letting users add scraper configurations to es_systems.cfg (maybe not the right place?)
Here's an example of what the segment looks like:
The idea is try to make scrapers as configurable as possible, but at the moment the only valid name is
gamesdband the only used child element of a scraper is<APIKEY>. The code I have works, but obviously this needs to be cleaned up.For one thing, ratings, developers, publishers and genres aren't yet supported.For another, it's a long way from truly configurable. But hopefully this is a good enough starting point for some feedback.Update
Basic support for scraping developers, publishers and genres has been added. Currently, there doesn't appear to be a way to access ratings through the TheGamesDB API. Fetching each requires a minimum of 3 synchronous API requests, at the moment. I expect that I'll want to make those asynchronous - similar to the image/thumbnail fetches - in the future. But it's a bit more complex than those because the fetched information is share-able between all games scraped with that scraper.
But I digress. Next up is refining the configuration files a bit.