update moduleutil to run sudo as user not root for test module button#5189
Closed
NiteRide wants to merge 1 commit into
Closed
update moduleutil to run sudo as user not root for test module button#5189NiteRide wants to merge 1 commit into
NiteRide wants to merge 1 commit into
Conversation
Author
|
@Alex-developer can you have a look at this PR? (I can't request to assign you as a reviewer directly.) Let me know of any issues. I found this while working on keolapse a while back, and again recently. |
Author
|
Never mind. There is a bug with this approach. 🤔 I'm going to delete this PR and look at it again another day.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [Test Module] button creating files and dirs as ROOT. eg. the user cannot normally delete without extra friction. Nor can endOfNight.sh automatically cleanup... Updates moduleUtil.php so that file and dir creation actions run as the user.
Let me know if you have any issues with this fix.