Ensuring NEURON 3d() functions target the correct section.#149
Open
aaberbach wants to merge 1 commit intoAllenInstitute:developfrom
Open
Ensuring NEURON 3d() functions target the correct section.#149aaberbach wants to merge 1 commit intoAllenInstitute:developfrom
aaberbach wants to merge 1 commit intoAllenInstitute:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was creating a cell model and came across an error in the following code:
bmtk/bmtk/simulator/bionet/morphology.py
Lines 51 to 57 in 022c24f
where the
h.x3d(i, sec=sec)goes out of bounds. This was caused by theh.n3d()not accessing the correct section. When nosecis provided, NEURON uses a default section, and in this case, it was incorrect. Therefore, I went through bmtk and filled insec=secfor these situations. This may not be necessary in all cases, but I think this is a situation where it is better to be safe than sorry.