Ignore invalid URLs that cause urljoin to raise.#393
Open
jyasskin wants to merge 2 commits intoAlir3z4:masterfrom
Open
Ignore invalid URLs that cause urljoin to raise.#393jyasskin wants to merge 2 commits intoAlir3z4:masterfrom
jyasskin wants to merge 2 commits intoAlir3z4:masterfrom
Conversation
This just copies the invalid URL into the markdown link verbatim instead of trying to join it to the base URL.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 97.23% 96.74% -0.50%
==========================================
Files 11 11
Lines 1122 1135 +13
==========================================
+ Hits 1091 1098 +7
- Misses 31 37 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just copies the invalid URL into the markdown link verbatim instead
of trying to join it to the base URL.