feature/add-optional-kwargs: Added optional kwargs#309
Open
098799 wants to merge 1 commit intoAlir3z4:masterfrom
Open
feature/add-optional-kwargs: Added optional kwargs#309098799 wants to merge 1 commit intoAlir3z4:masterfrom
098799 wants to merge 1 commit intoAlir3z4:masterfrom
Conversation
098799
force-pushed
the
feature/add-optional-kwargs
branch
from
30a6ae6 to
eec7917
Compare
098799
force-pushed
the
feature/add-optional-kwargs
branch
2 times, most recently
from
349bc17 to
37ec4fc
Compare
Most of the init arguments in the ``HTML2Text`` class are hardcoded in constants and modifiable only by the cli, not through the library usage. This adds the possibility to pass kwargs through the function call ``html2text`` or class init. Please note that the commit contains syntax that is not recognizable by ``mypy``, but is correct. Note: python/mypy#5719
098799
force-pushed
the
feature/add-optional-kwargs
branch
from
37ec4fc to
a6d9f9a
Compare
Owner
I consider that as a problem, but the approach doesn't look clean to me, regardless of of how mypy works with it, the code has become harder to read, especially when setattr is being used here. The code would be much easier to read when it's explicit and easily being able to follow. |
Author
|
Hey @Alir3z4, thanks for the reply. If you prefer, I can keep the current structure and replicate the big list once again in the kwargs of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the init arguments in the
HTML2Textclass are hardcoded inconstants and modifiable only by the cli, not through the library
usage. This adds the possibility to pass kwargs through the function
call
html2textor class init.Please note that the commit contains syntax that is not recognizable
by
mypy, but is correct. Note: python/mypy#5719