[OGUI-1854] Add native browser notification helper functions #3257
Conversation
hehoon
force-pushed
the
feature/FRM/OGUI-1854/native-browser-notification-helpers
branch
from
fb89f92 to
d05ba52
Compare
| * Calling this method directly is discouraged; it may be removed in future versions. | ||
| * @returns {boolean} Returns `true` if context is secure | ||
| */ | ||
| isContextSecure() { |
There was a problem hiding this comment.
As this method is private and used within the CopyToClipboardComponent.js only, could you please rather than deprecate it, update it to use the one you recommend?
There was a problem hiding this comment.
As this is not a class, the naming should be browserNotification maybe even adding something to point out is a utility package.
Given we also have BrowserStorage, maybe you want to create a directory for browser only and keep all related in there
| } | ||
|
|
||
| const permission = getBrowserNotificationPermission(); | ||
| if (permission === 'granted') { |
There was a problem hiding this comment.
Given that the permission value can only be: granted, default, denied, I think it would be good to have an object with these values in the file and reuse it from there.
In this way you can also use it as reference in docs with that getBrowserNotificationPermission can return
I have JIRA issue created
Changes: