Skip to content

Conversation

@Houwie7000
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • LHC fills page now has the efficiency column merged with Total runs duration.
  • LHC fills page after last run column has been removed.
  • LHC fills beam type has its '-' replaced with a newline.
  • LHC fills page is a little more compact.
  • LHC fills page add log to this fill button added to dropdown.
  • LHC fills page STABLE BEAM ONLY filter button is now on by default.

Notable changes for developers:

  • Table.js can now accepts a tableClasses property in its TableConfiguration object that apply those classes to the html table.

Changes made to the database:

  • None

@Houwie7000 Houwie7000 requested a review from graduta as a code owner November 19, 2025 13:14
@Houwie7000 Houwie7000 added frontend javascript Pull requests that update Javascript code labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.50%. Comparing base (0a110ef) to head (7cfac8e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/utilities/formatting/formatBeamType.js 0.00% 6 Missing ⚠️
lib/public/components/common/table/table.js 0.00% 3 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 3 Missing ⚠️
...lic/services/lhcFill/LhcFillStatisticsExtractor.js 0.00% 2 Missing ⚠️
lib/public/views/LhcFills/LhcFills.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2022      +/-   ##
==========================================
- Coverage   45.53%   45.50%   -0.03%     
==========================================
  Files        1021     1022       +1     
  Lines       17004    17014      +10     
  Branches     3080     3085       +5     
==========================================
  Hits         7743     7743              
- Misses       9261     9271      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 self-assigned this Nov 21, 2025
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the efficiency (percentage) should be added under the SB duration as the efficiency refers to what percent out of the SB duration was with data taking.

@graduta graduta merged commit 19c3921 into main Nov 25, 2025
21 of 24 checks passed
@graduta graduta deleted the improv/O2B-1479/LHC-fills-improvements branch November 25, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

4 participants