Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Use time range picker for runs start & stop filtering

@martinboulais martinboulais requested a review from graduta as a code owner March 28, 2024 18:25
@martinboulais martinboulais self-assigned this Mar 28, 2024
@martinboulais martinboulais requested a review from xsalonx March 28, 2024 18:25
@martinboulais martinboulais force-pushed the feature/O2B-532/use-time-range-filter-for-run-start-stop branch from 7d740bf to 30e512c Compare April 10, 2024 06:26
@martinboulais martinboulais force-pushed the feature/O2B-532/use-time-range-filter-for-run-start-stop branch 3 times, most recently from 959ebe0 to 0b8afc8 Compare April 22, 2024 06:31
@martinboulais martinboulais force-pushed the feature/O2B-532/use-time-range-filter-for-run-start-stop branch 2 times, most recently from 7ce8761 to 350e886 Compare May 22, 2024 09:28
@martinboulais martinboulais force-pushed the feature/O2B-532/use-time-range-filter-for-run-start-stop branch from 28e1f28 to 4aad374 Compare November 26, 2024 14:02
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 44.02%. Comparing base (6d2c9c9) to head (bc0babe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/common/form/inputs/DateTimeInputComponent.js 0.00% 32 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 21 Missing ⚠️
...omponents/common/form/inputs/DateTimeInputModel.js 0.00% 3 Missing ⚠️
...ents/Filters/common/filters/TimeRangeInputModel.js 0.00% 2 Missing ⚠️
...lic/components/Filters/RunsFilter/o2StartFilter.js 0.00% 1 Missing ⚠️
...blic/components/Filters/RunsFilter/o2StopFilter.js 0.00% 1 Missing ⚠️
...components/common/chart/rendering/ChartRenderer.js 0.00% 1 Missing ⚠️
...ic/components/common/formatting/formatTimeRange.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   43.59%   44.02%   +0.43%     
==========================================
  Files         893      893              
  Lines       15950    15864      -86     
  Branches     3001     2974      -27     
==========================================
+ Hits         6953     6984      +31     
+ Misses       8997     8880     -117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

First attempt at fixing tests

Fix more tests

Fix min/max

Implement review comments

Renaming ret

Fix broken imports

Fix tests
@martinboulais martinboulais force-pushed the feature/O2B-532/use-time-range-filter-for-run-start-stop branch from 4aad374 to 57d59cd Compare November 26, 2024 14:08
@martinboulais martinboulais merged commit a809bc7 into main Dec 12, 2024
22 of 23 checks passed
@martinboulais martinboulais deleted the feature/O2B-532/use-time-range-filter-for-run-start-stop branch December 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants