Skip to content

Support hybrid trace and add benchmark#48

Open
yitongh wants to merge 16 commits into
mainfrom
dev/hybridtrace
Open

Support hybrid trace and add benchmark#48
yitongh wants to merge 16 commits into
mainfrom
dev/hybridtrace

Conversation

@yitongh
Copy link
Copy Markdown
Contributor

@yitongh yitongh commented Jan 8, 2025

  • support hybrid trace
  • register FA as PyTorch op
  • add llm benchmark
  • move patch to accelerate.apply_patch

Comment thread benchmarks/benchmark.sh

declare -A BACKAND_PARAMS=(
["torchacc"]="--backend lazy"
["hybridtrace"]="--backend lazy --hybrid_trace"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little strange to specify both eager/lazy backend and partial_compile/hybrid_trace in the command. Can we hide the backend option in the command(reserve in the Backendconfig)?
for example, --lazy represents LTC trace and lazy mode, --eager represents eager mode and cuda native, --hybridtrace represents lazy mode but hybridtrace, --partial_compile represents eager mode but dynamo + xla.
We only need to check if xla is aviliable in the environment for lazy mode.
What's more, we need add comments or docs for these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants