Skip to content

Add qs and SeuratObject to renv#996

Merged
sjspielman merged 3 commits into
masterfrom
sjspielman/add-qs
May 12, 2026
Merged

Add qs and SeuratObject to renv#996
sjspielman merged 3 commits into
masterfrom
sjspielman/add-qs

Conversation

@sjspielman
Copy link
Copy Markdown
Member

From https://github.com/AlexsLemonade/training-modules/pull/990/changes#r3219607976

While adding qs I realized we need Seurat too. I did not want to put Seurat into our renv, but I think it's reasonable to put SeuratObject in. The only piece of code in the reference conversion script that needs the full Seurat package is as.SingleCellExperiment(), so we can just construct it manually with e.g.

sce <- SingleCellExperiment(
  assays = list(counts = mm_mets[["RNA"]]$counts)
)
stopifnot("bad conversion" = mm_mets@meta.data)
colData(sce) <- DataFrame(mm_mets@meta.data)

I think this is a good middle ground but it's not the most lightweight, so let me know if you prefer to not put this in renv at all.
While I was here I also update the renv settings json to get it to stop telling me to snapshot ScPCAr which we don't want snapshotted.

@sjspielman sjspielman requested a review from jashapiro May 12, 2026 16:55
Comment thread renv/settings.json
"bioconductor.version": "3.22",
"external.libraries": [],
"ignored.packages": [],
"ignored.packages": [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not installing this because it is too heavy with dependencies? We already have a lot in the repo, so I would not expect too many extra things to be pulled in.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just neither of us thought it belonged in renv necessarily when I filed that PR. We can put it in though, it won't be that heavy.

@jashapiro
Copy link
Copy Markdown
Member

From https://github.com/AlexsLemonade/training-modules/pull/990/changes#r3219607976

While adding qs I realized we need Seurat too. I did not want to put Seurat into our renv, but I think it's reasonable to put SeuratObject in. The only piece of code in the reference conversion script that needs the full Seurat package is as.SingleCellExperiment(), so we can just construct it manually with e.g.

sce <- SingleCellExperiment(
  assays = list(counts = mm_mets[["RNA"]]$counts)
)
stopifnot("bad conversion" = mm_mets@meta.data)
colData(sce) <- DataFrame(mm_mets@meta.data)

I think this is a good middle ground but it's not the most lightweight, so let me know if you prefer to not put this in renv at all. While I was here I also update the renv settings json to get it to stop telling me to snapshot ScPCAr which we don't want snapshotted.

We might as well add Seurat, I guess? People are gonna want it no matter what we do.

@sjspielman sjspielman requested a review from jashapiro May 12, 2026 18:30
Copy link
Copy Markdown
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sjspielman sjspielman merged commit 53558a8 into master May 12, 2026
7 checks passed
@sjspielman sjspielman deleted the sjspielman/add-qs branch May 12, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants