Add qs and SeuratObject to renv#996
Conversation
| "bioconductor.version": "3.22", | ||
| "external.libraries": [], | ||
| "ignored.packages": [], | ||
| "ignored.packages": [ |
There was a problem hiding this comment.
Are we not installing this because it is too heavy with dependencies? We already have a lot in the repo, so I would not expect too many extra things to be pulled in.
There was a problem hiding this comment.
No, just neither of us thought it belonged in renv necessarily when I filed that PR. We can put it in though, it won't be that heavy.
We might as well add Seurat, I guess? People are gonna want it no matter what we do. |
From https://github.com/AlexsLemonade/training-modules/pull/990/changes#r3219607976
While adding
qsI realized we need Seurat too. I did not want to put Seurat into our renv, but I think it's reasonable to putSeuratObjectin. The only piece of code in the reference conversion script that needs the full Seurat package isas.SingleCellExperiment(), so we can just construct it manually with e.g.I think this is a good middle ground but it's not the most lightweight, so let me know if you prefer to not put this in renv at all.
While I was here I also update the renv settings json to get it to stop telling me to snapshot
ScPCArwhich we don't want snapshotted.