feat: add tensor parallelism awareness for multi-GPU model fitting#277
Merged
AlexsJones merged 2 commits intoMar 23, 2026
Merged
Conversation
- supports_tp() and valid_tp_sizes() methods on LlmModel - Heuristic head count inference for Qwen, Llama, DeepSeek, Mistral, Gemma, Phi, MiniMax families - TensorParallel run mode with 0.9× speed penalty in fit analysis - TUI: TP compatibility filter (Shift-T) cycles All/TP=2/TP=3/TP=4 - Unit tests for TP logic and head count inference Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
what an awesome PR @michaeljabbour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supports_tp(tp_size)andvalid_tp_sizes()methods onLlmModelfor checking TP compatibilityRunMode::TensorParallelwith 0.9× speed penalty in fit analysisShift-T) cycles All → TP=2 → TP=3 → TP=4Files changed (9)
llmfit-core/src/models.rsllmfit-core/src/fit.rsTensorParallelrun mode, cluster-aware fit path (+54)llmfit-core/src/hardware.rscluster_mode,cluster_node_countfields (+10)llmfit-core/src/plan.rsllmfit-tui/src/tui_app.rsTpFilterenum, cycling, filter integration (+47)llmfit-tui/src/tui_events.rsShift-Tkeybinding (+3)llmfit-tui/src/tui_ui.rsllmfit-tui/src/serve_api.rsllmfit-tui/src/main.rsTest plan
supports_tp,valid_tp_sizes,infer_heads_from_namefor multiple model familiesShift-Tto cycle TP filter, verify model list updates🤖 Generated with Claude Code